Fix MATLAB interface samples #1911
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed a typo in Interface.concentrations
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1911 +/- ##
==========================================
- Coverage 74.11% 74.11% -0.01%
==========================================
Files 445 445
Lines 55454 55453 -1
Branches 9121 9121
==========================================
- Hits 41101 41098 -3
- Misses 11262 11263 +1
- Partials 3091 3092 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Changed refine criteria for Diff_flame
for axis for periodic_cstr.m sample
ssun30
force-pushed
the
matlab_fix_samples
branch
from
9a6a562 to
f8ebb67
Compare
Modified several samples to include this change
ischoegl
reviewed
Jun 21, 2025
There was a problem hiding this comment.
@ssun30 ... thanks for addressing!
Out of curiosity: for the Python API, all examples are tested as part of a CI job, see run-examples in .github/workflows/main.yml.
The relevant code is:
- name: Run the examples
# See https://unix.stackexchange.com/a/392973 for an explanation of the -exec part.
run: |
ln -s libcantera_shared.so build/lib/libcantera_shared.so.3
export LD_LIBRARY_PATH=build/lib
find samples/python -type f -iname "*.py" \
-exec sh -c 'for n; do echo "$n" | tee -a results.txt && python3 "$n" >> results.txt || exit 1; done' sh {} +
I believe it's possible to do something similar here as it's possible to run MATLAB scripts from the command line:
matlab -r "try, run('rankine.m'), catch, exit(1), end, exit(0)"
where I had set matlab to
alias matlab="/Applications/MATLAB_R2023b.app/bin/matlab -nojvm -nodesktop"
on macOS (fwiw, I just ran a quick test so the options may not be the greatest selection)
include correct units
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are numerous changes to class structures to the MATLAB interface that necessitate modifications to our current collection of MATLAB samples.
Changes proposed in this pull request
If applicable, fill in the issue number this pull request is fixing
Closes #1722
Checklist
scons build&scons test) and unit tests address code coverage